Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Alystrasz-Parkour-0.2.1 #14

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

Alystrasz
Copy link
Contributor

Parkour v0.2.1

Did I read the whole README file and understood all of its content?

YES

Did I update verified-mods.json with my new mod's information?

YES

Has a previous version of my mod been previously verified?

NO

Mod description

Reach all checkpoints and end the race as fast as you can.

Thunderstore link

https://northstar.thunderstore.io/package/Alystrasz/Parkour/

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we do not have the tooling yet to automate checking the repo against the Thunderstore mod, I only checked the Thunderstore mod (which is our ground source of truth anyway).

I checked there was no obvious malicious behaviour or files included in the zip. The only "dangerous" 1 functions are Safe I/O stuff and SquirrelHTTP but there's nothing that looks malicious there either.

Overall, good to mark as verified from my end.
(As usual, verification does not ensure correctness, only non-malicious behaviour. Correctness is responsibility of the mod author)

Footnotes

  1. "dangerous" is a bit too much maybe. Under the assumption that the native implementations are correct and secure, there's nothing dangerous here. However it's always recommended to use more of a Swiss cheese approach and also operate a bit under the assumption that a layer can fail.

@GeckoEidechse
Copy link
Member

Also we should really do a checklist for verifiers to go through and fill out or something, so that verification process has some resemblance of structure ^^

@GeckoEidechse GeckoEidechse changed the title Parkour gamemode Verify Alystrasz-Parkour-0.2.1 Dec 20, 2023
@GeckoEidechse GeckoEidechse added the verification request Request for verification label Dec 20, 2023
@GeckoEidechse GeckoEidechse merged commit 27c91e4 into R2Northstar:master Dec 20, 2023
2 checks passed
@Alystrasz Alystrasz deleted the parkour-mod branch December 21, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verification request Request for verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants