Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Action to check for tabs in JSON files #21

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

GeckoEidechse
Copy link
Member

Checks for tabs in all JSON files and fails if it finds any

 

Tabs vs Spaces

Before anyone complains why only spaces in JSON files instead of tabs for indentation:

  • We already use spaces, this PR changes nothing
  • It's way easier to check for tabs than spaces as you just need to check whether there's a \t as opposed having a parser that actually understands the JSON syntax.
  • When doing suggestions during code review on GitHub, adding a tab is really annoying as pressing tab moves the cursor to the next element so instead you have to copy-paste a tab character from somewhere else

@GeckoEidechse GeckoEidechse added the meta pr A PR that does not request verification but instead modifies tooling etc label Jan 12, 2024
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grep command looks fine, new CI job seems to be working according to run 20424196944.

@Alystrasz Alystrasz merged commit 09e5bd7 into master Jan 17, 2024
6 checks passed
@Alystrasz Alystrasz deleted the ci/check-for-tabs branch January 17, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta pr A PR that does not request verification but instead modifies tooling etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants