Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify x3Karma-HotPotato-1.1.0 #25

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

x3Karma
Copy link
Contributor

@x3Karma x3Karma commented Jan 21, 2024

HotPotato v1.1.0

Did I read the whole README file and understood all of its content?

YES

Did I update verified-mods.json with my new mod's information?

YES

Has a previous version of my mod been previously verified?

YES

Mod description

A new gamemode for Northstar Launcher featuring a classical twist on the original Hot Potato gamemodes.

Thunderstore link

https://northstar.thunderstore.io/package/x3Karma/HotPotato/

Full changelog is listed in my release notes.

@GeckoEidechse GeckoEidechse changed the title Update HotPotato to 1.1.0 Verify x3Karma-HotPotato-1.1.0 Jan 21, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we do not have the tooling yet to automate checking the repo against the Thunderstore mod, I only checked the Thunderstore mod (which is our ground source of truth anyway).

Verified by looking at the diff between this version and x3Karma-HotPotato-1.0.0

I checked there was no obvious malicious behaviour or files included in the zip. There's no use of "dangerous" 1 functions.

As usual, verification does not ensure correctness, only non-malicious behaviour. Correctness is responsibility of the mod author.

Footnotes

  1. e.g.: Safe I/O stuff and SquirrelHTTP. "dangerous" is a bit too much maybe. Under the assumption that the native implementations are correct and secure, there's nothing dangerous here. However it's always recommended to use more of a Swiss cheese approach and also operate a bit under the assumption that a layer can fail.

@GeckoEidechse GeckoEidechse merged commit 944132c into R2Northstar:master Jan 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants