Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reorganize workflows #29

Merged
merged 10 commits into from
Jan 29, 2024

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Jan 28, 2024

META PR, NO MOD VERIFICATION NEEDED

This PR separates CI workflows in two different flows: one dedicated to manifest verification, the other to mods verification.
The idea is to avoid running mods verification if manifesto checking fails.

Before PR

image

After PR

image

@Alystrasz Alystrasz marked this pull request as ready for review January 28, 2024 21:47
@GeckoEidechse GeckoEidechse self-requested a review January 28, 2024 22:06
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially, this PR just moves workflow steps around into different files without changing the logic (a few names or comments have been updated but that's it)

Not sure if the extra verified-mods.yml is really necessary but overall this is already an improvement.

.github/workflows/verified-mods.yml Show resolved Hide resolved
@GeckoEidechse GeckoEidechse changed the title build: Reorganize workflows ci Reorganize workflows Jan 29, 2024
@GeckoEidechse GeckoEidechse changed the title ci Reorganize workflows ci: Reorganize workflows Jan 29, 2024
@GeckoEidechse GeckoEidechse merged commit 658bb38 into R2Northstar:master Jan 29, 2024
3 checks passed
@Alystrasz Alystrasz deleted the build/reorganize-workflows branch January 29, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants