Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use f-string instead of .format() #32

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Jan 29, 2024

META PR, NO MOD VERIFICATION NEEDED

F-strings are generally nicer to read and as such recommended to use over .format().

Apparently they are also faster but that's not really a concern for us, lol

@GeckoEidechse
Copy link
Member Author

Setting back to draft while I get other stuff worked out first ^^

It's nicer to read and as such also recommended to use over `.format()`
@GeckoEidechse GeckoEidechse marked this pull request as ready for review January 30, 2024 15:21
@GeckoEidechse
Copy link
Member Author

Rebased and updated

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roses are red, this PR is fine.

@Alystrasz Alystrasz merged commit d3e5259 into master Jan 30, 2024
6 checks passed
@Alystrasz Alystrasz deleted the refactor/f-string branch January 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants