-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support reading mods from Northstar packages
directory
#417
Conversation
packages
directory
A few questions, for context, before I review:
|
Exactly :D
Cause it partially is. I'd have to do a bunch of refactoring before I can re-use the existing code, so I opted to just duplicating. Not the nicest but the fastest way to get it working. I'm planning to do it properly later but I'm too time restricted atm and the Northstar update is planned to be dropped this weekend so I want to get out support before that ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO:
Deleting Northstar mod does not clean up entire packages dir after deletionOn second thought, this is not really an issue. Might add a cleanup function for this later though.
Part of #415