Add online task R3BOnlineSyncCheck #898
Conversation
morze00
force-pushed
the
sync_check_online
branch
2 times, most recently
from
e9945b3 to
5a74d4f
Compare
| { | ||
| canvas->cd(i + 1); | ||
| TString hname = EnumName(i); | ||
| auto* fh2 = new TH2F(hname.Data(), hname.Data(), XBINS, XMIN, XMAX, YBINS, YMIN, YMAX); |
There was a problem hiding this comment.
Please, use here the new definition of histograms:
auto* fh2 = R3B::root_owned(hname.Data(), hname.Data(), XBINS, XMIN, XMAX, YBINS, YMIN, YMAX);
There was a problem hiding this comment.
sure, I will do it. In the meantime I have committed some other updates for the reader and online histograms
There was a problem hiding this comment.
I think it should be replaced like this:
auto* fh2 = R3B::root_owned(hname.Data(), hname.Data(), XBINS, XMIN, XMAX, YBINS, YMIN, YMAX);
this also requires inclusion of the header:
#include"R3BShared.h"
There was a problem hiding this comment.
ok, I think it is ready now. There are still a few minor clang-tidy warnings but I think they can be safely ignored. Let me know if I should modify anything else, otherwise this can be merged
morze00
force-pushed
the
sync_check_online
branch
2 times, most recently
from
61c01d0 to
1477003
Compare
| @@ -54,22 +54,40 @@ Bool_t R3BSyncCheckReader::Init(ext_data_struct_info* a_struct_info) | |||
| return kFALSE; | |||
| } | |||
| // Register output array in tree | |||
| FairRootManager::Instance()->Register("SyncCheckData", "SyncCheck", fArray, kTRUE); | |||
| FairRootManager::Instance()->Register("SyncCheckData", "SyncCheck", fArray, kFALSE); | |||
There was a problem hiding this comment.
This means that you don't want to store the sync info in the output root file, is this right?
There was a problem hiding this comment.
Indeed, I do not consider this data to be important in the output tree. It is primarily required for the online monitor. Anyway, I have just added a flag and a setter to store it optionally (see my last commit)
Update the reader for sync check
morze00
force-pushed
the
sync_check_online
branch
from
1477003 to
5e5c5fd
Compare
Add online task for sync check. This will need a revision when more sync values will be available in the unpacker.
Checklist:
devbranch