Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-tidy config for neuland and rolu #906

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

YanzhaoW
Copy link
Contributor

@YanzhaoW YanzhaoW commented Nov 10, 2023

Info:

  1. Add separate clang-tidy configuration for NeuLAND and ROLU.
  2. The default .clang-tidy located in the project root folder is now a link to config/clang_tidy/global.yml with exactly the same configuration.
  3. Configurations for NeuLAND Related folders enable stricter rules (I will personal resolve those warnings for any NeuLAND related PRs).
  4. All clang-tidy warnings are disabled for ROLU related detector (as requested from ROLU modified to also run with no trigger and online spectra added #896) because currently no one is available to dedicate on software development of the detector.
  5. Add an instruction for the clang-tidy configuration.

Related to #907


Checklist:

This was referenced Nov 10, 2023
@YanzhaoW YanzhaoW force-pushed the edwin_clangtidy branch 3 times, most recently from bbb6fd6 to c6ef4c2 Compare November 16, 2023 03:29
@YanzhaoW
Copy link
Contributor Author

Ok, all conflicts resolved. Change the old config to core.yml and apply it to the core utilities in R3BRoot. Put @klenze config to default.yml (which is basically everything disabled).

The core.yml is linked to .clang-tidy files in folder r3bbase and r3bsource/base.

The core configuration is, of course, subjected to any discussion, which should be focused on REASONS of programming and software (as the implementation of core functionalities already requires relative high level of programming).

@jose-luis-rs
Copy link
Contributor

Thanks

@jose-luis-rs jose-luis-rs merged commit 07b3a39 into R3BRootGroup:dev Nov 16, 2023
5 checks passed
@YanzhaoW YanzhaoW deleted the edwin_clangtidy branch January 10, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants