Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nifi helm charts #336

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Added nifi helm charts #336

merged 7 commits into from
Jan 6, 2025

Conversation

Hsankesara
Copy link
Member

Description of the change

Added support for NiFi deployment.

Benefits

NiFi can provide the user interface to create different ETL pipelines, which can be used to process and manipulate real-time data. The current version uses the cetic/helm-nifi but we can probably be going to move to radar-helm-charts/nifi in future.

Possible drawbacks

Though NiFi provides a UI-based ETL pipeline, it does consume a substantial amount of resources. Also, the cetic/helm-nifi is not being maintained anymore so we probably would need to maintain the helm charts in some capacity or find another alternative to keep up with the new updates.

Additional information

Checklist

  • Make sure application versions in compatiblity section of README is same as the versions tested in CI

@Hsankesara Hsankesara requested a review from keyvaann December 4, 2024 07:08
@Hsankesara Hsankesara changed the base branch from dev to release-1.2 December 4, 2024 08:39
@Hsankesara Hsankesara changed the base branch from release-1.2 to dev December 4, 2024 08:40
@Hsankesara
Copy link
Member Author

Not sure, if I should I change the base to release-1.2 #333 or not?

@@ -32,3 +32,5 @@ repositories:
url: https://radar-base.github.io/radar-helm-charts
- name: cp-radar
url: https://radar-base.github.io/cp-helm-charts
- name: cetic
url: https://cetic.github.io/helm-charts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mirror this chart in our radar-helm-charts external directory and add it from there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think I have opened a PR there -- RADAR-base/radar-helm-charts#302. I'll wait for it to get merged then.

@@ -564,3 +564,18 @@ velero:
bucket: radar-base-backups
config:
s3Url: https://s3.amazon.com # protocol should be specified

nifi:
_install: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention _chart_version and _extra_timeout values here

etc/base.yaml Outdated
auth:
singleUser:
username: username
password: password
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secrets should be in base-secrets.yaml and if should be distinguished if it needs to be auto generated or should be manual.

path: /nifi
className: nginx
annotations:
nginx.ingress.kubernetes.io/backend-protocol: HTTPS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the cert-manager annotation as exampled in here
https://github.com/RADAR-base/RADAR-Kubernetes/blob/dev/etc/graylog/values.yaml#L29

@keyvaann
Copy link
Collaborator

keyvaann commented Dec 4, 2024

@keyvaann
Copy link
Collaborator

keyvaann commented Dec 4, 2024

Not sure, if I should I change the base to release-1.2 #333 or not?

The release-1.2 branch is on a feature freeze mode and trying to only do bug fixes on it.

Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. Just a couple of comments

resources:
limits:
cpu: 4
memory: 16Gi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that much necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not necessary, I think I can remove it.

@@ -175,3 +175,13 @@ velero:
[default]
aws_access_key_id=change_me
aws_secret_access_key=change_me

nifi:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps these secrets can be initialised in the bin/generate-secrets script (just add lines for specific values using insert_secret)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script will auto generate any secret that has the value of secret

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok great, thanks

@Hsankesara Hsankesara merged commit 04cfc1d into dev Jan 6, 2025
2 of 3 checks passed
@Hsankesara Hsankesara deleted the nifi-integration branch January 6, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants