Fix schemaretriever #164
Merged
Fix schemaretriever #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bdegraaf1234
force-pushed
the
fix_schemaretriever
branch
from
1c85f5a to
bef688c
Compare
This was referenced Jun 5, 2024
Closed
Bdegraaf1234
force-pushed
the
fix_schemaretriever
branch
from
bef688c to
1653bb3
Compare
This was referenced Jun 5, 2024
pvannierop
reviewed
Jun 10, 2024
There was a problem hiding this comment.
What is the idea about the commented out SchemaRestClientIntegrationTest.kt and SchemaRestRetrieverIntegrationTest.kt? Should we deactivate these tests? And if so, would adding an @ignore annotation not be better?
Bdegraaf1234
force-pushed
the
fix_schemaretriever
branch
from
fe30b7f to
7e9045d
Compare
pvannierop
approved these changes
Jun 10, 2024
Bdegraaf1234
force-pushed
the
fix_schemaretriever
branch
from
7e9045d to
8e589c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues with basic authentication (see RADAR-base/RADAR-Schemas#368)
It seems that httpclient configuration was not properly passed to the SchemaRestClient