284 clear proofs #287
Merged
284 clear proofs #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us-aegs-and-load-them-when-clicked
…us-aegs-and-load-them-when-clicked
…to 230-proof-history-bar-keep-track-of-previous-aegs-and-load-them-when-clicked
…oad-them-when-clicked' of https://github.com/RAIRLab/Peirce-My-Heart into 230-proof-history-bar-keep-track-of-previous-aegs-and-load-them-when-clicked
…us-aegs-and-load-them-when-clicked
…us-aegs-and-load-them-when-clicked
…us-aegs-and-load-them-when-clicked
…oad-them-when-clicked' of github.com:James-Oswald/PeirceMyHeart into 284-clear-proofs
…/PeirceMyHeart into 284-clear-proofs
AnushaTiwari5
added
Enhancement
This was
linked to
issues
Dec 5, 2023
Closed
|
Looks like it might solve issue in pr #279 |
James-Oswald
previously approved these changes
Dec 5, 2023
Comment on lines
+33
to
+36
| currentProofTree = new AEGTree(); | ||
| if (treeContext.currentProofStep) { | ||
| currentProofTree.sheet = treeContext.currentProofStep.tree.sheet.copy(); | ||
| } |
There was a problem hiding this comment.
If we need this exact block of code in every single proof mode tool it should be turned into a helper function.
There was a problem hiding this comment.
This has been added to the master clean up issue.
AnushaTiwari5
dismissed
James-Oswald’s stale review
Made new changes for proof history bar
James-Oswald
previously approved these changes
Dec 6, 2023
Comment on lines
+33
to
+36
| currentProofTree = new AEGTree(); | ||
| if (treeContext.currentProofStep) { | ||
| currentProofTree.sheet = treeContext.currentProofStep.tree.sheet.copy(); | ||
| } |
…My-Heart into 284-clear-proofs
AnushaTiwari5
dismissed
James-Oswald’s stale review
More new changes don't you just love our coding
James-Oswald
approved these changes
Dec 7, 2023
| { | ||
| "Single Move": "mouse-pointer", | ||
| "Multi Move": "arrows", | ||
| Resize: "arrows-alt", |
There was a problem hiding this comment.
I'm suspicious that this may not work without quotations, though its possible it will, add them anyway for quality.
This was referenced Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear Proof and Proof Drag working