Fix issue 27 #28
Merged
Fix issue 27 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated no confounding code so that CSA models work throughout OPTIC. Fixed errors in autoreg model formulas. Updated apply_treatment_effect code, then modified concurrent method to work with new implementation. Updated code so that additional new model types will work with noconfounding (however, still need to update code for standard errors using these methods). This does not fix issues using CSA when model is concurrent!
Found issue in json file - there was a missing comma.
Changing to patch iteration rather than minor versioning.
pedroliman
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for work which debugged user error. Adds compatility for CSA model within noconfounding. Fixes errors in standard error code and when using autoregressive models.