Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md #32

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Update Readme.md #32

merged 1 commit into from
Jul 13, 2023

Conversation

smartm0use
Copy link
Contributor

Fixed Rust version requirement

@RCasatta
Copy link
Owner

Need to investigate, CI is apparently testing for 1.65

@RCasatta
Copy link
Owner

from the docs this PR is right https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.first

Copy link
Owner

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK (but I don't know exactly why CI is not catching this)
Please update also the github actions file to use 1.66.0

Readme.md Outdated Show resolved Hide resolved
@RCasatta
Copy link
Owner

Could you please:

  1. Squash the two commits 7d52b18 and 7d52b18 you usually don't want different commits of the same PR to touch the same lines
  2. in another or same commit, update here
    toolchain: ["1.65.0", "stable", "nightly"]
    from 1.65 to 1.66

Thanks, sorry for being pedantic

@RCasatta
Copy link
Owner

utACK 03e3b19

Thanks!

@RCasatta RCasatta merged commit ae858b1 into RCasatta:master Jul 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants