Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/count and vocabs-all endpoint #140

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

edmondchuc
Copy link
Collaborator

@edmondchuc edmondchuc commented Jul 31, 2023

This PR adds two additional endpoints:

  • /count
  • /v/vocabs/{curie}/all

These address the ideas discussed in the Prez meeting here #134 (comment).

@edmondchuc edmondchuc marked this pull request as draft July 31, 2023 10:24
@edmondchuc
Copy link
Collaborator Author

edmondchuc commented Aug 1, 2023

For some reasons, the tests in tests/object hang when trying to run . Maybe that's why they were not included in the set of tests to run in GitHub Actions.

@edmondchuc edmondchuc marked this pull request as ready for review August 1, 2023 06:01
Copy link
Collaborator

@jamiefeiss jamiefeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks good to me

@edmondchuc edmondchuc merged commit e75091a into edmond/feat/vocabs-api Aug 1, 2023
1 check passed
@edmondchuc edmondchuc deleted the edmond/feat/vocabs-all branch August 1, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants