Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triples for parent link components + Bugfix to remove links for top concepts / narrowers endpoints #247

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

recalcitrantsupplant
Copy link
Collaborator

  1. Add triples for the identifier and label of link parent components.
  2. Bugfix to prevent creation of links for top concepts/narrowers endpoints (which were generating incorrectly - and are not necessarily required.)

Example of triples now being added for parent components in a link:

exm:TopLevelConcept a skos:Concept ;
    dcterms:identifier "exm:TopLevelConcept"^^prez:identifier ;
    prez:label "The toppiest of concepts" ;
    prez:link "/catalogs/exm:VocPrezCatalog/collections/exm:SchemingConceptScheme/items/exm:TopLevelConcept" .

exm:VocPrezCatalog dcterms:identifier "exm:VocPrezCatalog"^^prez:identifier ;
    prez:label "A Demo Catalog" .

…dd bugfix to prevent creation of links for top concepts/narrowers endpoints (which were generating incorrectly - and are not necessarily required.)
@recalcitrantsupplant
Copy link
Collaborator Author

Will need minor changes after merging #245 and #246

Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks.

@lalewis1 lalewis1 merged commit 0849ac8 into main Jul 24, 2024
2 checks passed
@recalcitrantsupplant recalcitrantsupplant deleted the david/bugfix-and-add-breadcrumbs-identifiers branch August 15, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants