Open
Conversation
Contributor
PyeongGangKim
left a comment
PyeongGangKim
left a comment
There was a problem hiding this comment.
리뷰 하나 남겼어요~~확인 부탁드립니다
Comment on lines
44
to
+48
| @GetMapping("/shops/{id}") | ||
| public ResponseEntity<ShopResponse> searchShop(@PathVariable Long id) { | ||
| ShopResponseDto shopResponseDto = shopService.findOneById(id); | ||
| public ResponseEntity<ShopResponse> searchShop( | ||
| @Login LoginMember loginMember, | ||
| @PathVariable Long id | ||
| ) { |
Contributor
There was a problem hiding this comment.
login이 안되어 있을 경우 LoginMember가 null로 들어갈 거 같은데, 그 부분은 괜찮은건가요??
Contributor
Author
There was a problem hiding this comment.
extract을 할 때 ""로 반환되고 유효하지 않다면 LoginMember.anonymous() 가 반환되어 괜찮을 거 같습니다
실제로 searchShops에서도 쓰고 있었습니다!
@GetMapping("/shops")
public ResponseEntity<List<ShopSimpleResponse>> searchShops(
@Login LoginMember loginMember,
@ModelAttribute ShopSearchRequest condition,
@PageableDefault Pageable pageable
) {
gomster96
approved these changes
Sep 8, 2022
| </root> | ||
| </springProfile> | ||
| </configuration> No newline at end of file | ||
| </configuration> |
Contributor
There was a problem hiding this comment.
흠 제가 여기서 new line을 안했었네요... 감사합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
가게 상세 조회 유저별 좋아요 여부 판별
Trouble Shooting
ETC