Skip to content

닉네임 중복 체크 항상 200OK 보내는 문제 해결 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PyeongGangKim wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

닉네임 중복 체크 항상 200OK 보내는 문제 해결 #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24ed724
fix: duplicate 시 200OK로 보내는 문제 해결
PyeongGangKim Sep 7, 2022
1b76f1d
feat: cors localhost:3000 열기
PyeongGangKim Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/security
Open in desktop
Submodule security updated from 2c704c to 902679
2 changes: 1 addition & 1 deletion backend/src/main/java/com/handong/rebon/config/WebConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class WebConfig implements WebMvcConfigurer {
public void addCorsMappings(CorsRegistry registry) {
registry.addMapping("/**")
.allowedMethods("*")
.allowedOrigins("http://rebon.s3-website.ap-northeast-2.amazonaws.com/", "http://localhost:8080");
.allowedOrigins("http://rebon.s3-website.ap-northeast-2.amazonaws.com/", "http://localhost:3000", "http://localhost:8080");
}

@Override
Expand Down
15 changes: 8 additions & 7 deletions backend/src/main/java/com/handong/rebon/member/presentation/ApiMemberController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import com.handong.rebon.member.application.dto.response.MemberCreateResponseDto;
import com.handong.rebon.member.application.dto.response.MemberReadResponseDto;
import com.handong.rebon.member.presentation.dto.MemberAssembler;
import com.handong.rebon.member.presentation.dto.request.DuplicateRequest;
import com.handong.rebon.member.presentation.dto.request.MemberCreateRequest;
import com.handong.rebon.member.presentation.dto.request.MemberUpdateRequest;
import com.handong.rebon.member.presentation.dto.response.MemberCreateResponse;
Expand All @@ -35,13 +36,6 @@ public ResponseEntity<MemberCreateResponse> create(@RequestBody MemberCreateRequ
.body(MemberCreateResponse.from(response));
}

@PostMapping("/members/nickname/check-duplicate")
public ResponseEntity<Void> nicknameDuplicateCheck(@RequestBody String nickname) {
memberService.checkNicknameDuplicate(nickname);
return ResponseEntity.ok()
.build();
}

@RequiredLogin
@PatchMapping("/members")
public ResponseEntity<Void> update(
Expand All @@ -55,6 +49,13 @@ public ResponseEntity<Void> update(
.build();
}

@PostMapping("/members/nickname/check-duplicate")
public ResponseEntity<Void> nicknameDuplicateCheck(@RequestBody DuplicateRequest duplicateRequest) {
memberService.checkNicknameDuplicate(duplicateRequest.getNickname());
return ResponseEntity.ok()
.build();
}

@RequiredLogin
@GetMapping("/members")
public ResponseEntity<MemberReadResponse> getMemberInfo(@Login LoginMember loginMember) {
Expand Down
12 changes: 12 additions & 0 deletions ...end/src/main/java/com/handong/rebon/member/presentation/dto/request/DuplicateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.handong.rebon.member.presentation.dto.request;

import lombok.AllArgsConstructor;
import lombok.Getter;
import lombok.NoArgsConstructor;

@NoArgsConstructor
@AllArgsConstructor
@Getter
public class DuplicateRequest {
private String nickname;
}
9 changes: 6 additions & 3 deletions backend/src/test/java/com/handong/rebon/acceptance/member/MemberCreateAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.handong.rebon.acceptance.member;

import com.handong.rebon.acceptance.AcceptanceTest;
import com.handong.rebon.member.presentation.dto.request.DuplicateRequest;
import com.handong.rebon.member.presentation.dto.request.MemberCreateRequest;

import org.springframework.http.HttpStatus;
Expand Down Expand Up @@ -42,8 +43,9 @@ void saveMember() {
void checkDidNotDuplicateNickname() {
//given
String nickname = "ReBoN";
DuplicateRequest duplicateRequest = new DuplicateRequest(nickname);
//when
ExtractableResponse<Response> response = checkDuplicateNickname(nickname);
ExtractableResponse<Response> response = checkDuplicateNickname(duplicateRequest);

//then
assertThat(response.statusCode()).isEqualTo(HttpStatus.OK.value());
Expand All @@ -54,16 +56,17 @@ void checkDidNotDuplicateNickname() {
void checkDuplicatedNickname() {
//given
String nickname = "test";
DuplicateRequest duplicateRequest = new DuplicateRequest(nickname);
saveMember(new MemberCreateRequest("test@gmail.com", nickname, "google", true));

//when
ExtractableResponse<Response> response = checkDuplicateNickname(nickname);
ExtractableResponse<Response> response = checkDuplicateNickname(duplicateRequest);

//then
assertThat(response.statusCode()).isEqualTo(HttpStatus.BAD_REQUEST.value());
}

private ExtractableResponse<Response> checkDuplicateNickname(String nickname) {
private ExtractableResponse<Response> checkDuplicateNickname(DuplicateRequest nickname) {
return RestAssured.given(getRequestSpecification())
.log().all()
.contentType(APPLICATION_JSON_VALUE)
Expand Down