Skip to content

Commit

Permalink
Merge pull request #16 from RENCI/oneTwenty
Browse files Browse the repository at this point in the history
tidying up comments, variable names
  • Loading branch information
PhillipsOwen authored Jul 22, 2024
2 parents 650d8dc + 48cda05 commit b189fdc
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions src/common/pg_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def get_station_data(self, **kwargs) -> str:
if not nowcast_data.empty:
if not obs_data.empty:
# Check if for type of observations name and make appropiate changes
observation_name = getObsDataName(obs_data)
observation_name = self.get_obs_data_name(obs_data)

# Merge nowcast data with Obs data
obs_data = obs_data.merge(nowcast_data, on='time_stamp', how='outer')
Expand All @@ -342,8 +342,8 @@ def get_station_data(self, **kwargs) -> str:
observation_name = None
else:
if not obs_data.empty:
# Check if for type of observations name and make appropiate changes
observation_name = getObsDataName(obs_data)
# Check if for type of observations name and make appropriate changes
observation_name = self.get_obs_data_name(obs_data)
else:
# if obs_data empty observation_name = None
observation_name = None
Expand Down Expand Up @@ -467,7 +467,7 @@ def get_nowcast_station_data(self, station_name, start_date, end_date, data_sour
# Return Pandas dataframe
return ret_val

def getObsDataName(obs_data):
def get_obs_data_name(self, obs_data):
"""
Gets the observed name.
Expand All @@ -478,12 +478,13 @@ def getObsDataName(obs_data):
observation_name = [s for s in obs_data.columns.values if 'wave_height' in s][0]
else:
observation_name = [s for s in obs_data.columns.values if 'water_level' in s]

if len(observation_name) == 0:
observation_name = None
else:
observation_name = observation_name[0]

return(observation_name)
return observation_name

def get_obs_station_data(self, station_name, start_date, end_date) -> pd.DataFrame:
"""
Expand Down

0 comments on commit b189fdc

Please sign in to comment.