Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#31: Updated Scoring for OData Standard Display Names #32

Merged
merged 1 commit into from
Nov 9, 2023
Merged

#31: Updated Scoring for OData Standard Display Names #32

merged 1 commit into from
Nov 9, 2023

Conversation

darnjo
Copy link
Member

@darnjo darnjo commented Sep 12, 2023

Fixes #31.

cc: @mohit-s96

@darnjo darnjo linked an issue Sep 12, 2023 that may be closed by this pull request
Update ETL Lib to Always Use OData Values #31
Closed
mohit-s96
mohit-s96 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@mohit-s96 mohit-s96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine but we will need changes to the mocha tests (expected values) before this can be used on the cert API.

@darnjo darnjo merged commit e6c46dc into main Nov 9, 2023
1 check passed
@darnjo darnjo deleted the 31-update-etl-lib-to-always-use-odata-values branch November 9, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohit-s96 mohit-s96 mohit-s96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ETL Lib to Always Use OData Values
2 participants
@darnjo @mohit-s96