Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7: added accessor methods for standard metadata and lookup map #35

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

mohit-s96
Copy link
Member

@mohit-s96 mohit-s96 commented Nov 3, 2023

closes #7

As discussed, there is no IDX classification being done here hence the payloads property will be missing from standard metadata fields.

Edit: Added payloads from annotations 3c8304c

@mohit-s96 mohit-s96 added the etl label Nov 3, 2023
@mohit-s96 mohit-s96 self-assigned this Nov 3, 2023
@mohit-s96 mohit-s96 requested a review from darnjo November 3, 2023 14:18
@mohit-s96 mohit-s96 marked this pull request as ready for review November 3, 2023 14:21
@darnjo
Copy link
Member

darnjo commented Nov 9, 2023

Some conflicts now that the other branches have been merged but will do so after they've been fixed.

In terms of payloads, we'll want to pull those more dynamically into a in-memory cache. RESO is currently going through a process of having SMEs create payloads, so they will change much more often than the Data Dictionary metadata and ETL. They will probably have their own service - and in the long run we can probably make a sheet service, which contains all of this.

darnjo
darnjo previously approved these changes Nov 9, 2023
@mohit-s96 mohit-s96 requested a review from darnjo November 9, 2023 12:01
@darnjo darnjo merged commit e169031 into main Nov 15, 2023
1 check passed
@darnjo darnjo deleted the 7-add-computed-standard-metadata-and-lookupmap branch November 15, 2023 00:58
@mohit-s96 mohit-s96 restored the 7-add-computed-standard-metadata-and-lookupmap branch December 11, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace standard-metadata and lookup-map with Computed Versions
2 participants