Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#65: Update helper methods with version #66

Merged
merged 7 commits into from
Jun 4, 2024
Merged

#65: Update helper methods with version #66

merged 7 commits into from
Jun 4, 2024

Conversation

mohit-s96
Copy link
Member

closes #65

@mohit-s96 mohit-s96 requested a review from darnjo May 13, 2024 15:22
@mohit-s96 mohit-s96 marked this pull request as ready for review May 13, 2024 15:22
darnjo
darnjo requested changes May 13, 2024
View reviewed changes
lib/common.js Outdated Show resolved Hide resolved
lib/common.js Show resolved Hide resolved
lib/common.js Show resolved Hide resolved
lib/process-metadata.js Outdated Show resolved Hide resolved
lib/process-metadata.js Show resolved Hide resolved
@mohit-s96 mohit-s96 requested a review from darnjo May 14, 2024 07:05
darnjo
darnjo requested changes May 14, 2024
View reviewed changes
Copy link
Member

@darnjo darnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback to CURRENT_DD_VERSION should be done in the functions themselves if an invalid version is passed, not by the caller.

lib/common.js Outdated Show resolved Hide resolved
lib/common.js Outdated Show resolved Hide resolved
lib/common.js Show resolved Hide resolved
lib/process-metadata.js Outdated Show resolved Hide resolved
darnjo
darnjo approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@darnjo darnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a potential TODO but looks good otherwise.

@darnjo darnjo merged commit 22cd1fd into main Jun 4, 2024
1 check passed
@darnjo darnjo deleted the 65-update-helper-methods-with-version branch June 4, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnjo darnjo darnjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add version to helper functions that use standard metadata or lookup map
2 participants
@mohit-s96 @darnjo