Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#177: Ignored items not working with expansions #179

Merged
merged 19 commits into from
Oct 1, 2024

Conversation

darnjo
Copy link
Member

@darnjo darnjo commented Sep 11, 2024

Renamed branch. New PR.

One thing to look into is that it seems like we're getting a filename error on replication and validation that we're not getting in the current main branch.

Response info written to /data-availability-responses.json
Error: 'filename' must contain the name of a file to resolve
    at resolveFilePathSync (/common.js:594:11)
    at writeAnalyticsReports (/lib/replication/utils.js:821:38)
    at async replicate (/lib/replication/index.js:270:11)

lib/schema/index.js Outdated Show resolved Hide resolved
lib/schema/utils.js Show resolved Hide resolved
lib/schema/validate.js Outdated Show resolved Hide resolved
lib/schema/utils.js Fixed Show fixed Hide fixed
lib/schema/utils.js Dismissed Show dismissed Hide dismissed
@darnjo darnjo merged commit f5aed4b into main Oct 1, 2024
4 checks passed
@darnjo darnjo deleted the 177-ignored-items-not-working-with-expansions branch October 1, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants