Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#178: Changed Lookup Resource handling and removed additional fetch strategies #179

Merged
merged 1 commit into from
Dec 3, 2023
Merged

#178: Changed Lookup Resource handling and removed additional fetch strategies #179

merged 1 commit into from
Dec 3, 2023

Conversation

darnjo
Copy link
Member

@darnjo darnjo commented Dec 3, 2023

Closing #178.

  • OData native client library was throwing errors trying to page past 10,000 records so switched to deserializing JSON from raw input stream
  • Also removed unnecessary fetch strategies since Commander doesn't do data availability testing anymore
  • Ensured that logs would be written on fast fail

@darnjo darnjo linked an issue Dec 3, 2023 that may be closed by this pull request
Handle Empty Body Property #178
Closed
@darnjo darnjo self-assigned this Dec 3, 2023
@darnjo darnjo added the bug Something isn't working label Dec 3, 2023
@darnjo darnjo added this to the Backlog milestone Dec 3, 2023
@darnjo darnjo merged commit ad9477d into main Dec 3, 2023
2 checks passed
@darnjo darnjo deleted the 178-handle-empty-body-property branch December 3, 2023 02:13
@darnjo darnjo mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@darnjo darnjo

Labels
bug Something isn't working
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Handle Empty Body Property
1 participant
@darnjo