add sync in revert_genesis to show unhandled reorg #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will check what can be done |
zoedberg
force-pushed
the
sync_in_revert_genesis
branch
from
5020765 to
1163628
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 37.26% 37.26%
=======================================
Files 279 279
Lines 42807 42807
=======================================
Hits 15950 15950
Misses 26857 26857
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that bp-wallet doesn't handle bitcoin reorgs. Having a look at the code it seems that transactions and utxos are never removed from the cache, even if they disappear from the blockchain.
Run
cargo test --test transfers revert_genesis::case_1 -- --include-ignoredto see the issue.@dr-orlovsky could you please provide a fix for this?