Expose RgbWallet Structs #32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=====================================
Coverage 0.0% 0.0%
=====================================
Files 8 8
Lines 824 828 +4
=====================================
- Misses 824 828 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| all = ["cli", "log"] | ||
| default = ["cli", "electrum", "log"] |
There was a problem hiding this comment.
Why do we need cli feature as a default? Libraries do not need it
There was a problem hiding this comment.
Probably fine to remove it from here
| @@ -40,6 +40,7 @@ pub struct TerminalPath { | |||
| } | |||
|
|
|||
| #[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Debug)] | |||
| #[derive(Serialize, Deserialize)] | |||
There was a problem hiding this comment.
This doesn't need serde since has to be serialized as string representation. If you need binary serialziation as well, than we need a custom serde implementation which serializes as string for human_readable case
| @@ -28,6 +28,7 @@ use crate::descriptor::DeriveInfo; | |||
| use crate::{RgbDescr, SpkDescriptor}; | |||
|
|
|||
| #[derive(Copy, Clone, Ord, PartialOrd, Eq, PartialEq, Hash, Debug, Display)] | |||
| #[derive(Serialize, Deserialize)] | |||
Okay fine. As soon as version 0.11 is released, I will check if anything from this PR was left out. Thanks |
CC @cryptoquick @dr-orlovsky