static_tests: Add test for Rust code formatting rules #20886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
added
Area: build system
|
Hm, there is a holdup: The static tests are run in a different container than riotbuild, and that doesn't have Rust :-/ Should I just add it there? |
|
I would say yes. Is there an easy way to measure the extra time this will cost per static-test run? |
|
Hard to tell w/o knowing GitHub's container cache strategy, but I think that the time to fetch the container (10s in this case) will grow proportionally with its size in some approximation. |
|
Lets just do it. How bad can it be? 🙈 |
chrysn
added a commit
to chrysn-pull-requests/riotdocker
that referenced
this pull request
Oct 2, 2024
This is needed for the static tests introduced in [20886]; no need for nightly or target specific tools. [20886]: RIOT-OS/RIOT#20886
chrysn
added a commit
to chrysn-pull-requests/riotdocker
that referenced
this pull request
Oct 2, 2024
This is needed for the static tests introduced in [20886]; no need for nightly or target specific tools. [20886]: RIOT-OS/RIOT#20886
|
This got shut down by GitHub trying to do NLP and failing miserably, closing this through RIOT-OS/riotdocker#254 … and since I force-pushed to make it trigger again, I can't reopen either. Anyone ever heard of Forgejo? Updated PR incoming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
It is common for projects with Rust code to just enforce the code style suggested by Rust.
This adds a check to the static tests, and
Testing procedure
This PR should fail with a sensible message on the first run, and be green when I push the second commit fixing all the formatting errors (through the provided command).
Issues/PRs references
Thanks @Teufelchen1 for spotting the formatting errors.