-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/nucleo-f722ze: add ADC support #21233
Conversation
Wow, thank you for implementing this so quickly!
I assume()ed it was this line here, because it's the only assume(). RIOT/cpu/stm32/periph/adc_f4_f7.c Line 105 in f67055c
It's necessary to add a higher RIOT/boards/nucleo-f767zi/include/periph_conf.h Lines 210 to 212 in f67055c
The reason for that is that With that change it works as it should:
The ADC line for VBAT is pegged to zero, which I'm not sure why that is. But the NUCLEO-F722ZE does not have a battery holder. I'll check the schematic to see what's going on. |
Oh, nevermind, the GPIO for the VBAT pin is So from my side, this is good to merge with the one change. But I'm not a maintainer. |
d7ca65a
to
83a0c14
Compare
Thanks for testing this PR, finding bug ... and giving solution :D |
Wait... Vbat should work and show something high, because it is connected to +3.3V. I'll investigate :) |
This is funny again. So everything works as it should and the other Nucleos behave odd. To enable the V_BAT measurement, one is supposed to add With
So yes, you did nothing wrong, it works as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look straightforward enough and I've double-checked the pins with the pinout on https://doc.riot-os.org/group__boards__nucleo-f722ze.html.
Haven't tested this locally, but trusting @crasbe's reporting.
Thanks everyone!
Thank you @krzysztof-cabaj for doing this PR and thank you @mguetschow for checking and approving this so quickly! @krzysztof-cabaj if you want to, you can do the same for There are more Nucleo boards that are missing the ADC definitions, but I already bought 150€ worth of Nucleo boards this month for RIOT development, so that has to wait a little bit longer 😅 |
Thank you @crasbe for testing and @mguetschow for servicing this PR ... ... I started a while ago work on |
Contribution description
This PR adds ADC support for
nucleo-f722ze
.Testing procedure
Flash the board using
tests/periph/adc
program. Check if measured values changes when A0-A5 pins areconnected to the 3,3V, GND or to the potentiometer.
Unfortunately I don't have access to this board and cannot check if everything is working.
@crasbe - you mentioned in the PR #20971 that you have this board but it lacks configuration. Could you test it?
Issues/PRs references
PR #20971