11-lorawan: Remove task 06 GNRC LoRaWAN (ABP) #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some discussion it would seem like the best option to handle the generally untested task is to just remove it. This has not been testing is quite some time, likey due to the somewhat challenging setup requirering chipstack. The alternative would be to acutally implement the missing operations, however, the ABP generally is not used in production, so we would be testing something only used for testing... which seems a bit redundant.
|
ping @jia200x |
miri64
reviewed
Jan 27, 2025
miri64
approved these changes
Jan 28, 2025
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion it would seem like the best option to handle the generally untested task is to just remove it.
This has not been testing is quite some time, likey due to the somewhat challenging setup requirering chipstack. The alternative would be to acutally implement the missing operations, however, the ABP generally is not used in production, so we would be testing something only used for testing... which seems a bit redundant.