Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test for python 3.12 & fix linting error #3

Merged
merged 2 commits into from
Jun 5, 2024
Merged

CI: test for python 3.12 & fix linting error #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9505d6a
CI: test for python 3.12
miri64 Jun 5, 2024
080ea07
Use 'yield from' to satisfy linter
miri64 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tool supposed to run in CI. Why do we bother with anything than latest Python in the first place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My stance is: as long as it runs in those version, lets run it in those versions. People might need certain versions of python or whatever.


steps:
- uses: actions/checkout@main
Expand All @@ -31,7 +31,7 @@ jobs:
python -m pip install --upgrade pip
python -m pip install tox
- name: Lint with tox
if: matrix.python-version == 3.10
if: matrix.python-version == 3.12
run: tox -e black,codespell,flake8,lint
- name: Test with tox
run: |
Expand Down
6 changes: 2 additions & 4 deletions check_labels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,12 +392,10 @@ def remove_from_labels(self, label):
) from exc

def get_labels(self):
for label in self.labels:
yield label
yield from self.labels

def get_reviews(self):
for review in self.reviews:
yield review
yield from self.reviews

@pytest.mark.parametrize(
"value, labels, reviews, missing_approvals_label, exp",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = lint,codespell,flake8,black,{py37,py38,py39,py310,py311}-{test}
envlist = lint,codespell,flake8,black,{py37,py38,py39,py310,py311,py312}-{test}
skip_missing_interpreters = true
skipsdist = true

Expand Down