Revert "ci: temporarily disable "Rust build test"" #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 96287a8 from [249] that had been required to resolve a deadlock. [249]: RIOT-OS#249
|
Wait, that checkmark is green! I do have |
|
Our checkmarks have power, but merge pull requests is apparently still limited. |
|
Also, there's no hurry to merge -- this can just as well merge it right before merging the next PR, this shouldn't have changed the build output, but our builds are not exactly binary reproducible. |
hm, all Maintainers have "Write" permission, that should suffice actually to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 96287a8 from 249 that had been required to resolve a deadlock.
Casually looking at the finished Rust update action I found that the "temporary" #249 has been around for over a month now. I don't remember what the deadlock was with, and none of us left a note, I presume it was something with #249 -- but at any rate, should be resolved now (and build will confirm that).