-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UART wrapper (chrysn's cleanup) #143
Conversation
I've made a bit of a mess with which branch to push to, and GitHub's view of when things were pushed is inconsistent -- it shows "Use From for error conversion" before your review, but actually I don't think you've seen them. I don't think they are major, but maybe you'd like to revisit (best viewed individually) and the recent 9e052af (but that's just sequence changes) I'll do some squashing, trying to strike a balance between documenting the genesis and keeping small fixes out of the way; I'll force-push the tree-identical result. |
Co-authored-by: chrysn <chrysn@fsfe.org>
Co-authored-by: chrysn <chrysn@fsfe.org>
…tween nested scopes
9e052af
to
dcfeff9
Compare
Squashed now into what I think is a sensible sequence of ocmmits, leaning towards keeping history.
|
This funcitonality is not consistently exposed as functions in RIOT, even when `periph_uart_reconfigure` is present. (For example, samr21-xpro is missing it).
As a last-minute removal I had to ditch the Enabling auto-merge already; that will fail anyway if there is any follow-up trouble (which I don't expect). |
Sorry for not answering, I was very busy during the last weeks. Is there anything left to do @chrysn? |
Sure, that was a time period where one is bound to get mixed availabilities. I think all is done here :-) |
This PR just contains fixes relative to #39; let's keep discussion there, but it's a PR so that we can see what CI says.