Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob copy python #109

Merged
merged 22 commits into from
Oct 9, 2024
Merged

Blob copy python #109

merged 22 commits into from
Oct 9, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Oct 8, 2024 •
edited
Loading

Create an action to upload/download blobs using the Python library. README for details.

See it in action: RMI-PACTA/workflow.transition.monitor#364

@AlexAxthelm AlexAxthelm self-assigned this Oct 8, 2024
@AlexAxthelm AlexAxthelm mentioned this pull request Oct 9, 2024
Merged
1 task
@AlexAxthelm AlexAxthelm marked this pull request as ready for review October 9, 2024 12:03
@AlexAxthelm AlexAxthelm mentioned this pull request Oct 9, 2024
Closed
jdhoffa
jdhoffa approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain to me what a mime_type is?

Also, very NIT and def NB but you may want to run a linter? There's some conflicting style in the script.

@AlexAxthelm AlexAxthelm merged commit 637f054 into main Oct 9, 2024
@AlexAxthelm AlexAxthelm deleted the blob-copy-python branch October 9, 2024 18:08
@AlexAxthelm
Copy link
Contributor Author

Short version is that MIME type declares what data type is in the document, so that a browser knows how to handle it. The SDK defaults to application/octet-stream, which isn't useful, since most browsers download that. Setting it as text/html tells the browser to display it s a page. Same logic for all the other files.

https://developer.mozilla.org/en-US/docs/Web/HTTP/MIME_types

AlexAxthelm added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request Oct 9, 2024
@AlexAxthelm
Restore Report Links (#364)
e47e031 
Updates test workflow to use new action to transfer files to/from Azure
Blob storage for persistence.

Depends On:
- [ ] RMI-PACTA/actions#109

Closes #363 

Note for reviewers: PA2024CH reports are being sent to a private blob
store as of this PR (changed in #361) so only the GENERAL links work
here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman

Assignees

@AlexAxthelm AlexAxthelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa