Self Review

RMI-PACTA · Dec 19, 2023 · d08c69b · d08c69b
1 parent 2c058bf
commit d08c69b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/frontend/components/portfolio/ListView.vue b/frontend/components/portfolio/ListView.vue
@@ -98,7 +98,6 @@ const deleteSelected = () => Promise.all([selectedRows.value.map((row) => delete
       v-model:expanded-rows="expandedRows"
       :value="editorObjects"
       data-key="id"
-      class="portfolio-upload-table"
       size="small"
       sort-field="editorValues.value.createdAt.originalValue"
       :sort-order="-1"

diff --git a/frontend/i18n.config.ts b/frontend/i18n.config.ts
@@ -5,7 +5,7 @@ export default defineI18nConfig(() => ({
   missing: (locale, key, vm) => {
     // TODO(grady) figure out how to skip this if we're in production + just log.
     // Consider using process.env.NODE_ENV == 'prod', etc.
-    const fn = null // inject('handleMissingTranslation')
+    const fn = inject('handleMissingTranslation')
     if (fn) {
       const callable = fn as (locale: string, key: string) => void
       callable(locale, key)

diff --git a/frontend/pages/portfolios.vue b/frontend/pages/portfolios.vue
@@ -68,7 +68,7 @@ const activeIndex = computed<number>({
 </script>
 
 <template>
-  <StandardContent>
+  <StandardContent class="portfolios-page">
     <TitleBar :title="tt('Portfolios')" />
     <p>
       TODO(#80) Add Copy Here
@@ -104,20 +104,22 @@ const activeIndex = computed<number>({
 </template>
 
 <style lang="scss">
-.p-datatable.p-datatable-sm {
-  width: 100%;
+.portfolios-page {
+  .p-datatable.p-datatable-sm {
+    width: 100%;
 
-  .p-datatable-row-expansion td {
-    padding: 0 0.5rem;
-  }
+    .p-datatable-row-expansion td {
+      padding: 0 0.5rem;
+    }
 
-  .p-checkbox {
-    width: 1.25rem;
-    height: 1.25rem;
+    .p-checkbox {
+      width: 1.25rem;
+      height: 1.25rem;
 
-    .p-checkbox-box {
-      height: 100%;
-      width: 100%;
+      .p-checkbox-box {
+        height: 100%;
+        width: 100%;
+      }
     }
   }
 }