Reorder MSAL plugin functions #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcspragu
force-pushed
the
brandon/reorder
branch
from
0f0b9e7 to
da66f6e
Compare
I saw an error in dev (which I haven't been able to replicate) about some minified function/variable begin referenced before its definition, and I think it might be this, which can now be eagerly invoked in `handleResponse` as we do initialization synchronously In any case, it probably doesn't hurt
bcspragu
force-pushed
the
brandon/reorder
branch
from
da66f6e to
247dfc1
Compare
gbdubs
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: found the error locally, it was
userClientWithAuththat was out of order, fixed in this PR as wellI saw an error in dev (which I haven't been able to replicate) about some minified function/variable begin referenced before its definition, and I think it might be this, which can now be eagerly invoked in
handleResponseas we do initialization synchronouslyIn any case, it probably doesn't hurt