-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/cd: gains GH action to automate checks and tests #25
Conversation
Note: there are still many type check failures... I'm not entirely sure if/ how we do/ don't want to handle this. I will discuss this with @MonikaFu on Monday, and we will come to a decision. |
Ok scratch that, it seems that in the short-term setting We can explore migrating our existing JS to TS later, if we think it is a valuable thing to do. |
So it seems like the linter is still failing after #26 was merged. I would suggest that we merge this PR without solving those, and handle them in a separate issue, since they will likely require @MonikaFu to eventually have a look at, and she will be actively developing on a lot of those files next sprint. So I would say this is ready for review @AlexAxthelm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me? I've never set up JS checks before.
Sweet :-) Will wait for @MonikaFu to give it the once over before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will need to re-write big parts of the code anyway and I agree it is better to tackle the styling then.
I have added a
ci.yml
to run a series of tests and checks on this repo on every push tomain
.The following checks are conducted:
npm run test:unit
)npm run test:integration
)npm run lint
)npm run check
)Note: I expect currently that the integration tests, linter and type check will all fail at this stage.
I will open separate PRs to address those failures.
Closes #23