Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: volume trajectory is a small multiples plot with no built-in filters #43

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

MonikaFu
Copy link
Contributor

@MonikaFu MonikaFu commented Oct 4, 2024

Change the volume trajectory code so that it plots all technologies at once as small multiples with shared legend and footnote.

NOTE: this plot is not visually fully fledged out but it is working as expected and we can tweak the visuals later if we have the time.

@MonikaFu MonikaFu marked this pull request as draft October 4, 2024 20:45
@MonikaFu MonikaFu requested a review from jdhoffa October 4, 2024 20:46
@MonikaFu
Copy link
Contributor Author

MonikaFu commented Oct 4, 2024

@jdhoffa this is not ready for review just FYI

@MonikaFu MonikaFu marked this pull request as ready for review October 15, 2024 14:54
@MonikaFu
Copy link
Contributor Author

@jdhoffa this one is ready for review

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!
Things are really shaping up :-)

@MonikaFu MonikaFu merged commit 60979ff into main Oct 16, 2024
4 of 5 checks passed
@MonikaFu MonikaFu deleted the refactor-volume-trajectory branch October 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants