-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a mermaid flowchart #366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 29 29
Lines 3269 3269
=======================================
Hits 2617 2617
Misses 652 652 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting rid of a large png makes sense to me.
I would suggest we adjust the color to RMI color scheme and make this a bit larger though, I currently find this a bit delicate in size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
builds a flowchart programmatically, which is easier to adapt and avoids adding a large static image
does add a dependency on
DiagrammeR
, but it's a Suggest not an Importrender as (further customization could be done, e.g. the function names could be made links and I think color/shape/size can be controlled)
https://rmi-pacta.github.io/pacta.multi.loanbook/pr-preview/pr-366/articles/cookbook_running_the_analysis.html#structure-of-the-workflow
versus
https://rmi-pacta.github.io/pacta.multi.loanbook/articles/cookbook_running_the_analysis.html#structure-of-the-workflow