do not clean when building pkgdown site
#374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only reliable way I see to stop the pkgdown action from wiping the existing release site when building a dev site. The disadvantage is that if a page is completely removed, although it will not be linked anymore, it will still exist. This is a known [problem](r-lib/actions@dabdc15) that apparently there's currently no good known workaround for. In the r2dii packages I [implemented a manual switch](RMI-PACTA/r2dii.match#506) that one can use to wipe old files that should no longer exist.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 29 29
Lines 3269 3269
=======================================
Hits 2617 2617
Misses 652 652 ☔ View full report in Codecov by Sentry. |
|
jacobvjk
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only reliable way I see to stop the pkgdown action from wiping the existing release site when building a dev site. The disadvantage is that if a page is completely removed, although it will not be linked anymore, it will still exist. This is a known problem that apparently there's currently no good known workaround for. In the r2dii packages I implemented a manual switch that one can use to wipe old files that should no longer exist.