Fix/45 pass currencies explicitly #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 59.82% 59.82%
=======================================
Files 31 31
Lines 585 585
=======================================
Hits 350 350
Misses 235 235 ☔ View full report in Codecov by Sentry. |
This was referenced May 13, 2024
cjyetman
reviewed
May 16, 2024
cjyetman
reviewed
May 16, 2024
cjyetman
requested changes
May 16, 2024
Co-authored-by: CJ Yetman <cj@cjyetman.com>
|
@AlexAxthelm can you rebuild the docs please... I think the change I suggested probably causes a need for rebuild |
|
rendered. |
cjyetman
approved these changes
May 16, 2024
AlexAxthelm
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
May 16, 2024
cjyetman
pushed a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
currenciesobject explicitly tocheck_missing_currency()closes #45