Sanitize package details before exporting

RMI-PACTA · Mar 20, 2024 · 2df69db · 2df69db
1 parent 506af48
commit 2df69db
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/R/get_environment.R b/R/get_environment.R
@@ -64,8 +64,7 @@ get_package_info <- function(
 get_individual_package_info <- function(packagename) {
   log_trace("Getting package info for {packagename}.")
   pkg_details <- as.list(pkgdepends::lib_status(packages = packagename))
-  output <- list()
-  output[[packagename]] <- list(
+  details_list <- list(
     package = pkg_details[["package"]],
     version = pkg_details[["version"]],
     library = pkg_details[["library"]],
@@ -77,6 +76,13 @@ get_individual_package_info <- function(packagename) {
     remoteref = pkg_details[["remoteref"]],
     remotesha = pkg_details[["remotesha"]]
   )
-  output[[packagename]] <- pkg_details
+  clean_details_list <- lapply(
+    X = details_list,
+    FUN = function(x) {
+      ifelse(is.null(x), NA_character_, x)
+    }
+  )
+  output <- list()
+  output[[packagename]] <- clean_details_list
   return(output)
 }
diff --git a/tests/testthat/test-get_package_info.R b/tests/testthat/test-get_package_info.R
@@ -104,11 +104,11 @@ test_that("get_individual_package_info collects information for local packages c
     )
     expect_identical(
       package_info[["rmini"]][["remoteref"]],
-      NA #logical
+      NA_character_
     )
     expect_identical(
       package_info[["rmini"]][["remotesha"]],
-      NA #logical
+      NA_character_
     )
   })
 })