Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/24 Update package infor functions #26

Merged
merged 19 commits into from
Aug 6, 2024
Merged

Conversation

AlexAxthelm
Copy link
Collaborator

Some refactoring to get_individual_package_info() to simplify outputs, and reduce dependence on "unofficial" component s of output of pkgload functions.

Closes #24
coincidentally Closes #16

@AlexAxthelm AlexAxthelm changed the title Fix/24 fix pkg info tests Fix/24 Update package infor functions Aug 1, 2024
`pak` doesn't have information about packages installed with R CMD Check
@AlexAxthelm AlexAxthelm self-assigned this Aug 1, 2024
@AlexAxthelm AlexAxthelm added the ADO label Aug 1, 2024
use the fallback mode of `switch`
RSPM repos don't show as `CRAN` in `repotype`, but do show as `standard`
in the `remotetype`
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (5b48393) to head (9a9484c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   97.59%   97.65%   +0.05%     
==========================================
  Files           7        7              
  Lines         499      511      +12     
==========================================
+ Hits          487      499      +12     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm marked this pull request as ready for review August 1, 2024 12:57
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but can you explain a bit more in the comment what the problem was that was causing inconsistent test failures, and how this fixes that?

I don't entirely understand why these changes are necessary (beyond solving failing local tests)

@AlexAxthelm AlexAxthelm merged commit 512e154 into main Aug 6, 2024
20 checks passed
@AlexAxthelm AlexAxthelm deleted the fix/24-fix-pkg-info-tests branch August 6, 2024 07:30
@AlexAxthelm
Copy link
Collaborator Author

I think that the common issue that I was seeing is that I was depending on some fields in the output of pkgdepends::lib_status that aren't guaranteed to be there. This change basically introduces some logic so that it only includes non-NULL values for those fields when relevant.

@jdhoffa
Copy link
Member

jdhoffa commented Aug 6, 2024

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants