-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/24 Update package infor functions #26
Conversation
is redundant with `built`
`pak` doesn't have information about packages installed with R CMD Check
use the fallback mode of `switch`
RSPM repos don't show as `CRAN` in `repotype`, but do show as `standard` in the `remotetype`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 97.59% 97.65% +0.05%
==========================================
Files 7 7
Lines 499 511 +12
==========================================
+ Hits 487 499 +12
Misses 12 12 ☔ View full report in Codecov by Sentry. |
that operator was introduced in R 4.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but can you explain a bit more in the comment what the problem was that was causing inconsistent test failures, and how this fixes that?
I don't entirely understand why these changes are necessary (beyond solving failing local tests)
I think that the common issue that I was seeing is that I was depending on some fields in the output of |
Makes sense! |
Some refactoring to
get_individual_package_info()
to simplify outputs, and reduce dependence on "unofficial" component s of output ofpkgload
functions.Closes #24
coincidentally Closes #16