Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git utilities #9

Merged
merged 27 commits into from
Apr 8, 2024
Merged

Git utilities #9

merged 27 commits into from
Apr 8, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Apr 3, 2024

Another PR towards the manifest export

this one adds utilities for identifying git status on a directory, and surfacing any changes from upstream or local HEAD (dirty repo).

Notable updates:

  • adds get_git_info which returns a list with git info about a repo specified
  • Adds a call to get_git_info to get_individual_package_info for packages installed from local directory or loaded with devtools/pkgload

@AlexAxthelm AlexAxthelm changed the base branch from feat/1-export-manifests to main April 3, 2024 13:23
@AlexAxthelm AlexAxthelm changed the base branch from main to feat/1-export-manifests April 3, 2024 13:23
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 94.81481% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 90.13%. Comparing base (eecbd85) to head (c951bc9).

❗ Current head c951bc9 differs from pull request most recent head 0a2889a. Consider uploading reports for the commit 0a2889a to get more accurate results

Files Patch % Lines
R/git.R 93.85% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/1-export-manifests       #9      +/-   ##
===========================================================
+ Coverage                    86.41%   90.13%   +3.71%     
===========================================================
  Files                            4        5       +1     
  Lines                          162      294     +132     
===========================================================
+ Hits                           140      265     +125     
- Misses                          22       29       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm marked this pull request as ready for review April 8, 2024 12:43
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple NB comments/ questions, but LGTM and functions well locally.

Very cool PR in general :-)

@jdhoffa
Copy link
Member

jdhoffa commented Apr 8, 2024

Related: I know this package is meant to be "minimal" but probably a good idea to explain that it's for tests in a separate repo, so that we don't accidentally delete it. See RMI-PACTA/minimal.r.package#1

@AlexAxthelm AlexAxthelm merged commit 10a062a into feat/1-export-manifests Apr 8, 2024
15 checks passed
@AlexAxthelm AlexAxthelm deleted the git-utilities branch April 8, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants