Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep: match_name gains more informative warn and error messages with bad sector classifications #463

Merged
merged 2 commits into from
Mar 22, 2024
Merged

upkeep: match_name gains more informative warn and error messages with bad sector classifications #463

merged 2 commits into from
Mar 22, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Mar 20, 2024

Screenshot 2024-03-20 at 13 18 35

Closes #447

@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label Mar 20, 2024
@jdhoffa jdhoffa requested a review from jacobvjk March 20, 2024 12:19
@jdhoffa jdhoffa marked this pull request as draft March 20, 2024 16:21
@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 20, 2024

Converting to draft since changes in r2dii.data are causing checks to fail.

@jdhoffa jdhoffa marked this pull request as ready for review March 22, 2024 09:24
@jdhoffa jdhoffa requested a review from cjyetman March 22, 2024 09:25
@jdhoffa jdhoffa merged commit 40f1482 into main Mar 22, 2024
24 checks passed
@jdhoffa jdhoffa deleted the 447-warn_if_classification_not_present branch March 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

@jacobvjk jacobvjk Awaiting requested review from jacobvjk jacobvjk is a code owner

Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
2 participants
@jdhoffa @cjyetman