use pkgdown defaults where possible and modernize custom navbar specs #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobvjk
approved these changes
Aug 26, 2024
cjyetman
added a commit
to RMI-PACTA/r2dii.data
that referenced
this pull request
Aug 26, 2024
modernizing pkgdown config in line with: - RMI-PACTA/r2dii.match#499 - RMI-PACTA/r2dii.match#500 - RMI-PACTA/r2dii.match#502
cjyetman
added a commit
to RMI-PACTA/r2dii.analysis
that referenced
this pull request
Aug 26, 2024
modernizing pkgdown config in line with: - RMI-PACTA/r2dii.match#499 - RMI-PACTA/r2dii.match#500 - RMI-PACTA/r2dii.match#502
cjyetman
added a commit
to RMI-PACTA/r2dii.analysis
that referenced
this pull request
Aug 26, 2024
modernizing pkgdown config in line with: - RMI-PACTA/r2dii.match#499 - RMI-PACTA/r2dii.match#500 - RMI-PACTA/r2dii.match#502
cjyetman
added a commit
to RMI-PACTA/r2dii.data
that referenced
this pull request
Aug 26, 2024
* Update _pkgdown.yml modernizing pkgdown config in line with: - RMI-PACTA/r2dii.match#499 - RMI-PACTA/r2dii.match#500 - RMI-PACTA/r2dii.match#502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompted by trying to fix the navbar text showing in black instead of white as with the RMI template (which this does seem to fix)
This pkgdown config must have been written before pkgdwon used the modern
navbar > structureandnavbar > componentsproperties to customize the navbar. Additionally, pkgdown (now?) has default navbar items that can be used/placed in the structure without having to explicitly define them in the components section, which this leverages to reduce complexity and allow things to be automatically defined.The "Articles" menu was explicitly defined only pointing to two specific vignettes (ignoring any others). I maintained this behavior, but I suggest that this may not be ideal.
The "News" menu was customized to include a link to the "r2dii blog" which is still just a template with no actual content. I maintained this behavior, but I suggest that this may not be ideal.