This repository was archived by the owner on Mar 25, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
add default 2023Q4 config #136
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3625964
add default 2023Q4 config
cjyetman 268c3cc
Merge branch 'main' into add-default-2023Q4-config
cjyetman de2bd60
add `factset_industry_map_bridge_filename`
cjyetman f192844
Merge branch 'main' into add-default-2023Q4-config
cjyetman bdbe25d
Merge branch 'main' into add-default-2023Q4-config
cjyetman 58e365c
add `factset_manual_pacta_sector_override`
cjyetman 5a2ec24
add `_filename` suffix
cjyetman a96f286
add AI dataset filenames
cjyetman 6e34fde
change default "desktop" config to use 2023Q4
cjyetman 965c2da
Update from main
cjyetman e6c114b
Merge branch 'main' into add-default-2023Q4-config
cjyetman 3a98177
Merge branch 'main' into add-default-2023Q4-config
cjyetman 00c26bc
add more parameters to review
cjyetman 87eeee0
Merge branch 'main' into add-default-2023Q4-config
cjyetman ab84e6f
Merge branch 'main' into add-default-2023Q4-config
cjyetman 1097f53
Update config.yml
cjyetman 91f94bb
Merge branch 'main' into add-default-2023Q4-config
cjyetman 4b47c5f
feat(deploy): 144 Add 2023Q4_azure config
AlexAxthelm cea4775
feat(deploy): 144 Add filepaths
AlexAxthelm 6dfc6d6
inherit `docker` config
cjyetman 3b96db5
Merge branch 'main' into add-default-2023Q4-config
cjyetman 77920d0
Merge branch 'main' into add-default-2023Q4-config
cjyetman 102a95e
Merge branch 'main' into add-default-2023Q4-config
cjyetman f0fb939
Merge branch 'main' into add-default-2023Q4-config
cjyetman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none of these exist directly in the raw AI data for 2023
"Passenger" and "Freight" do exist separately in the raw AI data for 2023
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is the right person to tag for input on this? @Antoine-Lalechere @NickPACTA ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we/I have to dig into the code and really clearly wrap my head around where/how they're being used, and verify if they exist anywhere in the data that might hit that code. If not, then I think it would be best to remove these (from the 2023Q4 config anyway).
On the other side, it might be prudent to review the relevant list of technologies that do exist in 20223Q4 and consider if any of them should be added here. For that, I'm honestly unsure who would/should make that decision. Maybe Nick?