Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to code for CI checks #64

Merged
merged 17 commits into from
Apr 3, 2024
Merged

Updates to code for CI checks #64

merged 17 commits into from
Apr 3, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Mar 12, 2024

This PR addresses errors surfaced by the new CI checks from R.yml suite of checks in https://github.com/RMI-PACTA/Actions.

  • Now passes R CMD Check
    • additions to .Rbuildignore
    • testing dependencies added to DESCRIPTION
    • functions from utils namespaced
    • Non-ASCII characters (in override mapping) replaced with \\u strings
  • Version bump
  • Documentation updates

Closes #63

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 5.57%. Comparing base (98e5f97) to head (04e3fc8).

Files Patch % Lines
R/export_manifest.R 0.00% 6 Missing ⚠️
R/export_pacta_files.R 0.00% 3 Missing ⚠️
R/zzz.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #64      +/-   ##
========================================
- Coverage   5.58%   5.57%   -0.01%     
========================================
  Files         13      14       +1     
  Lines        806     807       +1     
========================================
  Hits          45      45              
- Misses       761     762       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 12, 2024

Docker build status

Commit time Git sha Image
2024-03-12T13:37:16Z 735c8eb ghcr.io/rmi-pacta/workflow.factset:pr-64
History
Commit time Git sha Image
2024-03-12T13:37:16Z 735c8eb ghcr.io/rmi-pacta/workflow.factset:pr-64
2024-03-12T13:41:12Z 04e3fc8 ghcr.io/rmi-pacta/workflow.factset:pr-64
2024-03-12T12:59:03Z 2e48768 ghcr.io/rmi-pacta/workflow.factset:pr-64
2024-03-12T13:30:57Z 8a2f843 ghcr.io/rmi-pacta/workflow.factset:pr-64
2024-03-12T12:31:37Z 713d017 ghcr.io/rmi-pacta/workflow.factset:pr-64
2024-03-12T12:19:16Z 947c70b ghcr.io/rmi-pacta/workflow.factset:pr-64
History JSON`[{"commit_time":"2024-03-12T13:37:16Z","git_sha":"735c8eb31b174400e544e37fcc3cd6233591f712","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T13:41:12Z","git_sha":"04e3fc85336409de5302017127f923d75858d7e5","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T12:59:03Z","git_sha":"2e487687002272fc728b07063c8dc3f7f54d91a1","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T13:30:57Z","git_sha":"8a2f843864113bf34fe770af2f197027047ffd14","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T12:31:37Z","git_sha":"713d017958c671c141c26cd6de2dfe8f0dca28a6","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T12:19:16Z","git_sha":"947c70bc62b28ff5b7f2bdd56fba2a7bb515f921","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"}]`

@AlexAxthelm AlexAxthelm marked this pull request as ready for review March 12, 2024 13:47
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa and removed request for cjyetman April 2, 2024 11:59
@cjyetman
Copy link
Member

cjyetman commented Apr 2, 2024

Not sure what the intent for this PR is. The title suggests it has to do with actions, but there don't seen to be any changes to the actions? Seems like a bunch of random clean-up bits? codecov tests are failing too

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this PR is to satisfy the linter and R package checks that will be introduced in #65.

The changes LGTM, but please rename the PR to something more descriptive, then I will approve.

@AlexAxthelm AlexAxthelm changed the title Use actions branch with R CMD CHECK Updates to code for CI checks Apr 3, 2024
@AlexAxthelm AlexAxthelm requested a review from jdhoffa April 3, 2024 09:21
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AlexAxthelm AlexAxthelm merged commit ffea968 into main Apr 3, 2024
13 of 15 checks passed
@AlexAxthelm AlexAxthelm deleted the ci/65-r-cmd-check branch April 3, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run R CMD Check against code
3 participants