-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to code for CI checks #64
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
========================================
- Coverage 5.58% 5.57% -0.01%
========================================
Files 13 14 +1
Lines 806 807 +1
========================================
Hits 45 45
- Misses 761 762 +1 ☔ View full report in Codecov by Sentry. |
Suppresses NOTE in R CMD Check about unused import
This reverts commit 22ee67a.
Docker build status
History
History JSON`[{"commit_time":"2024-03-12T13:37:16Z","git_sha":"735c8eb31b174400e544e37fcc3cd6233591f712","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T13:41:12Z","git_sha":"04e3fc85336409de5302017127f923d75858d7e5","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T12:59:03Z","git_sha":"2e487687002272fc728b07063c8dc3f7f54d91a1","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T13:30:57Z","git_sha":"8a2f843864113bf34fe770af2f197027047ffd14","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T12:31:37Z","git_sha":"713d017958c671c141c26cd6de2dfe8f0dca28a6","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"},{"commit_time":"2024-03-12T12:19:16Z","git_sha":"947c70bc62b28ff5b7f2bdd56fba2a7bb515f921","image":"ghcr.io/rmi-pacta/workflow.factset:pr-64"}]` |
Not sure what the intent for this PR is. The title suggests it has to do with actions, but there don't seen to be any changes to the actions? Seems like a bunch of random clean-up bits? codecov tests are failing too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, this PR is to satisfy the linter and R package checks that will be introduced in #65.
The changes LGTM, but please rename the PR to something more descriptive, then I will approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR addresses errors surfaced by the new CI checks from
R.yml
suite of checks in https://github.com/RMI-PACTA/Actions..Rbuildignore
utils
namespaced\\u
stringsCloses #63