Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command flow #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Command flow #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64d0c6e
Increment version number to 0.0.0.9009
AlexAxthelm Dec 17, 2024
d015a69
Add `commands`/`report` key to JSON schema
AlexAxthelm Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: workflow.pacta.report
Title: Reporting functionality for PACTA
Version: 0.0.0.9008
Version: 0.0.0.9009
Authors@R:
c(person(given = "Alex",
family = "Axthelm",
Expand Down
3 changes: 3 additions & 0 deletions inst/extdata/parameters/report_default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"commands": {
"report": true
},
"reporting": {
"scenarioGeography": "Global",
"sectorList": [
Expand Down
14 changes: 14 additions & 0 deletions inst/extdata/schema/reportingParameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,19 @@
"$comment": "Created by Alex Axthelm, aaxthelm@rmi.org",
"type": "object",
"properties": {
"commands": {
"type": "object",
"description": "Commands to run.",
"properties": {
"report": {
"type": "boolean",
"description": "Whether to create an interactive report."
}
},
"required": [
"report"
]
},
"portfolio": {
"$ref": "portfolio.json"
},
Expand Down Expand Up @@ -163,6 +176,7 @@
"allOf": [
{
"required": [
"commands",
"portfolio",
"reporting",
"user"
Expand Down
3 changes: 3 additions & 0 deletions tests/config/full_params_2023Q4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"resultsURL": "https://pactadatadev.blob.core.windows.net/ghactions-workflow-pacta-results/76/merge/latest/full_params_2023Q4/output_dir",
"benchmarksURL": "https://pactadatadev.file.core.windows.net/workflow-prepare-pacta-indices-outputs/2023Q4_20240529T002355Z",
"parameters": {
"commands": {
"report": true
},
"portfolio": {
"holdingsDate": "2023-12-31",
"name": "Default Portfolio",
Expand Down
Loading