Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prechecks #83

Merged
merged 22 commits into from
Aug 14, 2024
Merged

Add Prechecks #83

merged 22 commits into from
Aug 14, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Aug 8, 2024

Add functions to check if process is likely to run successfully prior to running.

Mainly centered around ensuring that required input files exist, and output directories are writable.

depends on RMI-PACTA/pacta.workflow.utils#28

Closes #61
Closes #69

Copy link

github-actions bot commented Aug 8, 2024

Docker build status

commit_time git_sha image
2024-08-13T13:59:53Z 07cf749 ghcr.io/rmi-pacta/workflow.pacta:pr-83

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 67.96117% with 33 lines in your changes missing coverage. Please review.

Project coverage is 15.87%. Comparing base (d6eea34) to head (07cf749).

Files Patch % Lines
R/run_pacta.R 0.00% 12 Missing ⚠️
R/calc_weights_and_outputs.R 75.75% 8 Missing ⚠️
R/run_audit.R 75.86% 7 Missing ⚠️
R/run_analysis.R 79.31% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #83       +/-   ##
==========================================
+ Coverage   0.00%   15.87%   +15.87%     
==========================================
  Files          4        4               
  Lines        347      441       +94     
==========================================
+ Hits           0       70       +70     
- Misses       347      371       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm marked this pull request as ready for review August 13, 2024 14:14
@AlexAxthelm
Copy link
Contributor Author

Marking as ready for review, even though the deps-main check is failing.

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question of clarification, but looks good to me!

R/calc_weights_and_outputs.R Show resolved Hide resolved
@AlexAxthelm AlexAxthelm merged commit 82bbc29 into main Aug 14, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check portfolios exist before loading data Check that output dir is writable
2 participants