Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to include real estate #361

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update dependencies to include real estate #361

wants to merge 11 commits into from

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Sep 26, 2024 •
edited
Loading

Not to be merged until dependencies are resolved.

Updates build configuration to use latest version of testing RE files.

Depends On:

@jdhoffa
Copy link
Member

jdhoffa commented Sep 26, 2024

@AlexAxthelm just flagging that I don't expect this to work, since the user_results directory will need to include the new real_estate directory? Unless you already added those on Azure.

See https://github.com/RMI-PACTA/user_results/pull/24/commits/1cebba7eb90f6d00e38c8d3a46e5e7da6c611a32

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Docker build status

commit_time git_sha project_code holdings_date language peer_group report summary image
2024-10-11T11:23:56Z 988f597, GENERAL 2022Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20241011T112656Z
2024-10-11T11:23:56Z 988f597, GENERAL 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20241011T112657Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 DE bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 DE other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 EN assetmanager Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 EN bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 EN insurance Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 EN pensionfund Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 FR bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z 988f597, PA2024CH 2023Q4 FR other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20241011T112656Z
2024-10-11T11:23:56Z, 988f597, "ghcr.io/rmi-pacta/workflow.transition.monitor:pr-361"

@AlexAxthelm AlexAxthelm mentioned this pull request Oct 9, 2024
Merged
1 task
AlexAxthelm added a commit that referenced this pull request Oct 9, 2024
@AlexAxthelm
Restore Report Links (#364)
e47e031 
Updates test workflow to use new action to transfer files to/from Azure
Blob storage for persistence.

Depends On:
- [ ] RMI-PACTA/actions#109

Closes #363 

Note for reviewers: PA2024CH reports are being sent to a private blob
store as of this PR (changed in #361) so only the GENERAL links work
here.
@AlexAxthelm AlexAxthelm marked this pull request as ready for review October 11, 2024 13:29
@AlexAxthelm AlexAxthelm requested review from jdhoffa, MonikaFu and cjyetman and removed request for jdhoffa and MonikaFu October 11, 2024 13:29
@AlexAxthelm AlexAxthelm mentioned this pull request Oct 11, 2024
Open
@jdhoffa
Copy link
Member

jdhoffa commented Oct 11, 2024

Again, I can't actually approve this, but looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman Awaiting requested review from cjyetman

@jdhoffa jdhoffa Awaiting requested review from jdhoffa

@MonikaFu MonikaFu Awaiting requested review from MonikaFu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa