Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove invalid holdings after audit #395

Merged
merged 7 commits into from
Jan 28, 2025
Merged

remove invalid holdings after audit #395

merged 7 commits into from
Jan 28, 2025

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Jan 25, 2025 •
edited
Loading

cjyetman added a commit to RMI-PACTA/workflow.pacta that referenced this pull request Jan 26, 2025
@cjyetman
remove invalid holdings after audit
9ac8525 
- related RMI-PACTA/workflow.transition.monitor#395
@cjyetman cjyetman mentioned this pull request Jan 26, 2025
Draft
@cjyetman cjyetman marked this pull request as ready for review January 26, 2025 02:26
@cjyetman cjyetman requested a review from AlexAxthelm as a code owner January 26, 2025 02:26
@cjyetman cjyetman requested a review from jdhoffa January 26, 2025 02:29
@jdhoffa
Copy link
Member

jdhoffa commented Jan 27, 2025 •
edited
Loading

This PR looks reasonable, but I would like to inspect the output report before approving.

Unfortunately, CI was disabled due to 60 days of inactivity on this repo. I have manually re-enabled it.
CJ can you add a commit to this PR to trigger it, so we can get a Docker build with this change and inspect the results?

I've also manually triggered a run from this branch here:
https://github.com/RMI-PACTA/workflow.transition.monitor/actions/runs/12984291187

@github-actions GitHub Actions
Copy link

Docker build status

commit_time git_sha project_code holdings_date language peer_group report summary image
2025-01-27T14:10:31Z d4add6e, GENERAL 2022Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2022q4_general:20250127T141238Z
2025-01-27T14:10:31Z d4add6e, GENERAL 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_general:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 DE bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 DE other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 EN assetmanager Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 EN bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 EN insurance Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 EN other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 EN pensionfund Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 FR bank Report Summary transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z d4add6e, PA2024CH 2023Q4 FR other Report transitionmonitordockerregistry.azurecr.io/rmi_pacta_2023q4_pa2024ch:20250127T141237Z
2025-01-27T14:10:31Z, d4add6e, "ghcr.io/rmi-pacta/workflow.transition.monitor:pr-395"

@cjyetman
Copy link
Member Author

@jdhoffa CI is running properly now

jdhoffa
jdhoffa approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic inspected and makes sense.
CI outputs reviewed, and all tables and plots look as I would expect.

I think this is good to merge!

@cjyetman cjyetman merged commit 943cb6c into main Jan 28, 2025
22 checks passed
@cjyetman cjyetman deleted the remove-invalid-holdings-after-audit branch January 28, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@AlexAxthelm AlexAxthelm Awaiting requested review from AlexAxthelm AlexAxthelm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjyetman @jdhoffa